This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/commit] procfs.c: Remove unused functions and make many functions static


On Fri, 4 May 2012, Maciej W. Rozycki wrote:

> > Even if the initial intention was to provide an API, I do not think
> > it's a good idea to keep maintaining dead code.  Making functions
> > static is often a big help in figuring out the potential call sites
> > (you immediately know that you do not have to grep the entire repo).
> 
>  I agree, I just raised my point for the avoidance of doubt.  Also we have 
> a public repository these days where individual changes can be reasonably 
> easy to track for any code to resurrect if needed -- something that GDB 
> certainly did not have back in 1991.

 Hmm, here's a dumb question as a followup, following a situation I've 
just experienced -- can this stuff be needed by anything external on 
Solaris, similarly to some functions pulled from GDB by libthread_db.so.1 
from glibc?

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]