Re: [RFC] - Exposing find_pc_line through Python API

[Doug Evans <dje at google dot com>]

On Fri, May 11, 2012 at 9:34 AM, Siva Chandra <sivachandra@google.com> wrote:
> On Fri, May 11, 2012 at 2:45 AM, Doug Evans <dje@google.com> wrote:
>> I think we need to specify what the result is if there is no sal for
>> the specified pc.
>> ...
>> "actual" can be deleted now.
>
> I have addressed these two comments. ?The patch is attached.
>
> 2012-05-11 ?Siva Chandra Reddy ?<sivachandra@google.com>
>
> ? ? ? ?Add a new function gdb.find_pc_line to the Python API.
> ? ? ? ?* NEWS (Python Scripting): Add entry about the new function.
> ? ? ? ?* python/python.c (gdbpy_find_pc_line): New function which
> ? ? ? ?implements gdb.find_pc_line.
> ? ? ? ?(GdbMethods): Add entry for the new function.
>
> ? ? ? ?doc/
> ? ? ? ?* gdb.texinfo (Basic Python): Add description about the function
> ? ? ? ?gdb.find_pc_line
>
> ? ? ? ?testsuite/
> ? ? ? ?* gdb.python/python.c: Add a new breakpoint comment.
> ? ? ? ?* gdb.python/python.exp: Add tests to test gdb.find_pc_line.
>
> Thanks,
> Siva Chandra

Thanks.
The patch is ok with me.

A question occurred to me, and I'm not suggesting it has to be
answered before the patch can go in.
In vliw architectures one pc value can be associated with multiple
lines (maybe even symtabs, depending on possible future symtab
implementations).
In this particular case I think we can wait until there's a pressing
need to address it.
I just wanted to throw this out there.