This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] CR16 Simulator fix for gdb 7.4

From: Mike Frysinger <vapier at gentoo dot org>
To: gdb-patches at sourceware dot org
Cc: Tom Tromey <tromey at redhat dot com>, Kaushik Phatak <Kaushik dot Phatak at kpitcummins dot com>, "Jayant R. Sonar" <Jayant dot Sonar at kpitcummins dot com>, Prafulla Thakare <Prafulla dot Thakare at kpitcummins dot com>
Date: Sun, 13 May 2012 15:06:11 -0400
Subject: Re: [Patch] CR16 Simulator fix for gdb 7.4
References: <C6CA53A2A46BA7469348BDBD663AB65834AB01D8@KCHJEXMB01.kpit.com> <87sjf8p0by.fsf@fleche.redhat.com>

On Thursday 10 May 2012 10:39:13 Tom Tromey wrote:
> >>>>> "Kaushik" == Kaushik Phatak <Kaushik.Phatak@kpitcummins.com> writes:
> Kaushik> I am not able to figure out the reason why the attached hunk
> Kaushik> (nltvals.def) has been removed from the sources, maybe
> Kaushik> regenerate missed it out.
> 
> I don't think this patch is ok as-is.
> The top of nltvals.def says:
> 
> /* This file is machine generated by gennltvals.sh.  */
> 
> So, I think the bug must either be in gennltvals.sh, or in one of its
> input files, and the proper way to fix this would be to find the
> original bug, fix it, and re-run gennltvals.sh.

correct, this patch is wrong.  please see:
	http://sourceware.org/bugzilla/show_bug.cgi?id=12862
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

References:
- [Patch] CR16 Simulator fix for gdb 7.4
  - From: Kaushik Phatak
- Re: [Patch] CR16 Simulator fix for gdb 7.4
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]