This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] microMIPS support
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 17 May 2012 16:06:37 +0100
- Subject: Re: [PATCH] microMIPS support
- References: <alpine.DEB.1.10.1204241843340.19835@tp.orcam.me.uk> <83k414fjmp.fsf@gnu.org> <alpine.DEB.1.10.1204252339450.19835@tp.orcam.me.uk> <83haw6io8k.fsf@gnu.org> <alpine.DEB.1.10.1204261802540.19835@tp.orcam.me.uk> <8362cmi65h.fsf@gnu.org> <alpine.DEB.1.10.1204262305130.19835@tp.orcam.me.uk> <83y5ph6nqj.fsf@gnu.org> <alpine.DEB.1.10.1204302334520.19835@tp.orcam.me.uk> <83k40usfjk.fsf@gnu.org>
On Wed, 2 May 2012, Eli Zaretskii wrote:
> > gdb/doc/gdb.texinfo:36670: `MIPS Breakpoint Kinds' has no Up field (perhaps incorrect sectioning?).
> >
> > if I add a lone @node definition, or that plus:
> >
> > gdb/doc/gdb.texinfo:36670: warning: unreferenced node `MIPS Breakpoint Kinds'.
> >
> > if I place a @menu reference to that node in any of the upper sections.
>
> That's most probably because you added only some of the menus, not all
> of them. The minor variation of your patch below doesn't have this
> problem, it produces an Info manual without any warnings or errors.
I added only some of the menus by your explicit request. You rejected my
proposal that I made in response which added all of them and that was only
trivially different to the version you have proposed now.
> > I'll be pushing it in this form as soon as the MIPS16 manual
> > function call change has been committed.
>
> I believe committing a patch over objections of the responsible
> maintainer is against the rules described in MAINTAINERS (as I
> understand them). So please don't do that.
Certainly, next time I'll just drop any changes to the manual I disagree
with.
> Please use the slightly modified patch below instead.
Thanks for your proposal, even though my original concern about pages
containing single-entry menus still stands. This doesn't really matter
however for two reasons, first and foremost because you have the power to
override my objection to any changes to the manual, and second because it
contains changes irrelevant to my change and as such I cannot integrate
them. Please split changes to the existing pieces of the manual off and
commit them separately. I'll extract the rest and fold into my change.
I'll be doing the final round of testing of the microMIPS feature now,
now that I made a final adjustment that I found necessary after
investigation related to some changes I posted more recently. I want to
push the microMIPS change by the end of tomorrow at the latest.
> (After you install your patch, I will follow up with a patch that
> changes all occurrences of "MIPS" to use @acronym. I already have
> that patch ready on my box.)
I appreciate your effort. Thank you.
Maciej