This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA-v2/ARI fix] Remove use of abort function in common/buffer.c
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: 'Pedro Alves' <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 22 May 2012 14:18:32 +0200
- Subject: Re: [RFA-v2/ARI fix] Remove use of abort function in common/buffer.c
- References: <4fbb59b7.44e2440a.48c4.ffffab13SMTPIN_ADDED@mx.google.com> <4FBB5D9B.5070202@redhat.com> <000c01cd3813$32090b40$961b21c0$@muller@ics-cnrs.unistra.fr>
Hi Pierre, Hi Pedro,
Thanks for taking care of this, Pierre.
> + /* new_buffer is non NULL otherwise
> + xrealloc calls malloc_failure which does not return here. */
I suggest a slightly different way of saying this:
/* xrealloc guaranties that new_buffer cannot be null. */
It avoids the problem with the location of the line break and any issue
with punctuation...
--
Joel