This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add support for Tilera TILE-Gx processor (part 3/3: gdbserver)


On 05/24/2012 12:59 PM, Jeff Kenton wrote:

> On 05/23/2012 01:49 PM, Pedro Alves wrote:
>> On 05/21/2012 03:29 PM, Jeff Kenton wrote:
>>>      * Makefile.in: Add tilegx dependencies.
>>>      * configure.srv: Add tilegx dependencies.
>>>      * linux-tile-low.c: New file.
>> This needs to be more specific.  Something like:
>>
>>       * Makefile.in (SFILES): Add linux-tile-low.c.
>>        (linux-tile-low.o, reg-tilegx.o, reg-tilegx.c): New rules.
>>       * configure.srv: Handle tilegx-*-linux*.
>>       * linux-tile-low.c: New file.
>>
>>
>> Otherwise looks fine, thanks.
>>
>> Same comment about ps_get_thread_area though.
>>
> 
> Pedro,
> 
> How is this different from your comment about ps_get_thread_area in your response to part 2?


Not sure what you mean.  It's the same comment, but applied to gdbserver.  If a ps_get_thread_area
function should be added to gdb/tilegx-linux-nat.c, then one should also be added to
gdbserver/linux-tile-low.c.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]