This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] bfd: Use size_t for length argument totarget_read_memory function passed into bfd_elf_bfd_from_remote_memory
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: binutils at sourceware dot org, gdb-patches at sourceware dot org
- Date: Mon, 28 May 2012 16:41:22 +0530
- Subject: Re: [PATCH] bfd: Use size_t for length argument totarget_read_memory function passed into bfd_elf_bfd_from_remote_memory
- References: <20120528143520.29254d79@spoyarek> <20120528110313.GH3086@bubble.grove.modra.org>
On Mon, 28 May 2012 20:33:13 +0930, Alan wrote:
> On Mon, May 28, 2012 at 02:35:20PM +0530, Siddhesh Poyarekar wrote:
> > 2012-05-28 Siddhesh Poyarekar <siddhesh@redhat.com>
> >
> > * bfd-in.h (bfd_elf_bfd_from_remote_memory): Make LEN
> > argument of target_read_memory as size_t.
> > * bfd-in2.h: Regenerate.
> > * elf-bfd.h (elf_backend_bfd_from_remote_memory): Make LEN
> > argument of target_read_memory as size_t.
> > (_bfd_elf32_bfd_from_remote_memory): Likewise.
> > (_bfd_elf64_bfd_from_remote_memory): Likewise.
> > * elf.c (bfd_elf_bfd_from_remote_memory): Likewise.
> > * enfcode.h (NAME): Likewise.
>
> Since Jan has already given the OK, and these functions are only used
> by gdb, binutils maintainers hardly need to look at the patch. OK
> anyway, but please fix the ChangeLog
>
> * elfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Likewise.
>
Thanks, fixed ChangeLog for bfd below as per your suggestion.
Regards,
Siddhesh
2012-05-28 Siddhesh Poyarekar <siddhesh@redhat.com>
* bfd-in.h (bfd_elf_bfd_from_remote_memory): Make LEN argument
of target_read_memory as size_t.
* bfd-in2.h: Regenerate.
* elf-bfd.h (elf_backend_bfd_from_remote_memory): Make LEN
argument of target_read_memory as size_t.
(_bfd_elf32_bfd_from_remote_memory): Likewise.
(_bfd_elf64_bfd_from_remote_memory): Likewise.
* elf.c (bfd_elf_bfd_from_remote_memory): Likewise.
* enfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Likewise.