This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Rename cleanup_undefined_types -> cleanup_undefined_stabs_types
- From: dje at google dot com (Doug Evans)
- To: gdb-patches at sourceware dot org
- Date: Tue, 29 May 2012 11:57:29 -0700 (PDT)
- Subject: [commit] Rename cleanup_undefined_types -> cleanup_undefined_stabs_types
Hi.
Just a bit of cleanup.
The function is stabs specific, so this makes it easier to identify it
as such in buildsym.c.
2012-05-29 Doug Evans <dje@google.com>
* stabsread.h (cleanup_undefined_stabs_types): Renamed from
cleanup_undefined_types.
* stabsread.c (cleanup_undefined_stabs_types): Ditto.
All callers updated.
Index: buildsym.c
===================================================================
RCS file: /cvs/src/src/gdb/buildsym.c,v
retrieving revision 1.95
diff -u -p -r1.95 buildsym.c
--- buildsym.c 10 May 2012 19:59:12 -0000 1.95
+++ buildsym.c 29 May 2012 18:51:32 -0000
@@ -49,7 +49,7 @@
#include "buildsym.h" /* Our own declarations. */
#undef EXTERN
-/* For cleanup_undefined_types and finish_global_stabs (somewhat
+/* For cleanup_undefined_stabs_types and finish_global_stabs (somewhat
questionable--see comment where we call them). */
#include "stabsread.h"
@@ -1001,13 +1001,13 @@ end_symtab (CORE_ADDR end_addr, struct o
(this needs to be done before the finish_blocks so that
file_symbols is still good).
- Both cleanup_undefined_types and finish_global_stabs are stabs
+ Both cleanup_undefined_stabs_types and finish_global_stabs are stabs
specific, but harmless for other symbol readers, since on gdb
startup or when finished reading stabs, the state is set so these
are no-ops. FIXME: Is this handled right in case of QUIT? Can
we make this cleaner? */
- cleanup_undefined_types (objfile);
+ cleanup_undefined_stabs_types (objfile);
finish_global_stabs (objfile);
if (pending_blocks == NULL
Index: stabsread.c
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.c,v
retrieving revision 1.147
diff -u -p -r1.147 stabsread.c
--- stabsread.c 18 Apr 2012 06:46:46 -0000 1.147
+++ stabsread.c 29 May 2012 18:51:32 -0000
@@ -4598,7 +4598,7 @@ cleanup_undefined_types_1 (void)
this unit. */
void
-cleanup_undefined_types (struct objfile *objfile)
+cleanup_undefined_stabs_types (struct objfile *objfile)
{
cleanup_undefined_types_1 ();
cleanup_undefined_types_noname (objfile);
Index: stabsread.h
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.h,v
retrieving revision 1.29
diff -u -p -r1.29 stabsread.h
--- stabsread.h 7 Feb 2012 04:48:22 -0000 1.29
+++ stabsread.h 29 May 2012 18:51:32 -0000
@@ -129,7 +129,7 @@ EXTERN int n_this_object_header_files;
EXTERN int n_allocated_this_object_header_files;
-extern void cleanup_undefined_types (struct objfile *);
+extern void cleanup_undefined_stabs_types (struct objfile *);
extern long read_number (char **, int);