This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] fix some comments in buildsym.c
- From: dje at google dot com (Doug Evans)
- To: gdb-patches at sourceware dot org
- Date: Tue, 29 May 2012 13:24:32 -0700 (PDT)
- Subject: [commit] fix some comments in buildsym.c
Hi.
Just some minor comment fixes and improvements.
Committed.
2012-05-29 Doug Evans <dje@google.com>
* buildsym.c (block_compar): Fix comment.
(end_symtab): Fix and clarify some comments.
Index: buildsym.c
===================================================================
RCS file: /cvs/src/src/gdb/buildsym.c,v
retrieving revision 1.96
diff -u -p -r1.96 buildsym.c
--- buildsym.c 29 May 2012 18:54:50 -0000 1.96
+++ buildsym.c 29 May 2012 20:21:45 -0000
@@ -907,7 +907,7 @@ watch_main_source_file_lossage (void)
}
}
-/* Helper function for qsort. Parametes are `struct block *' pointers,
+/* Helper function for qsort. Parameters are `struct block *' pointers,
function sorts them in descending order by their BLOCK_START. */
static int
@@ -1126,7 +1126,7 @@ end_symtab (CORE_ADDR end_addr, struct o
{
/* Since we are ignoring that subfile, we also need
to unlink the associated empty symtab that we created.
- Otherwise, we can into trouble because various parts
+ Otherwise, we can run into trouble because various parts
such as the block-vector are uninitialized whereas
the rest of the code assumes that they are.
@@ -1196,7 +1196,8 @@ end_symtab (CORE_ADDR end_addr, struct o
SYMBOL_SYMTAB (BLOCK_FUNCTION (block)) = symtab;
/* Note that we only want to fix up symbols from the local
- blocks, not blocks coming from included symtabs. */
+ blocks, not blocks coming from included symtabs. That is why
+ we use ALL_DICT_SYMBOLS here and not ALL_BLOCK_SYMBOLS. */
ALL_DICT_SYMBOLS (BLOCK_DICT (block), iter, sym)
if (SYMBOL_SYMTAB (sym) == NULL)
SYMBOL_SYMTAB (sym) = symtab;