This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 06/10] Java language

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> -static void insert_exp (int, struct expression *);
Sergio> +static void insert_exp (struct parser_state *, int, struct expression *);

If you ever want to do another cleanup in this area, here's an
opportunity :)

IMNSHO language parsers should not be manipulating the expout data
structure like this.  copy_exp is likewise naughty.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]