This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FYI: fix latent bug in dw2_find_symbol_file


On Mon, Jun 11, 2012 at 1:57 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> You need to call init_cutu_and_read_dies in both debug-types and
> Doug> non-debug-types cases. ?When DWO files are in use DW_AT_name lives
> Doug> in the DWO file. ?OTOH TUs typically don't have DW_AT_name (you
> Doug> need to look at DW_AT_decl_file). ?OTOOH this function is only
> Doug> called by find_main_filename.
>
> What gcc branch should I use to test this?
> And do I need gold?
>
> Doug> I'm tempted to rename the routine {,*_}find_function_file (or some
> Doug> such) and have dw2_find_symbol_file ignore TUs.
>
> Fine by me, but I don't plan to do it.

Well, there's only 5 or so places you need to change for the renaming. :-)

What I'm saying is the patch is wrong for TUs but TUs are irrelevant
here anyway.
What did you want to test?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]