This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New ARI warning Wed Jun 20 01:56:10 UTC 2012


On Tue, Jun 19, 2012 at 6:56 PM, GDB Administrator
<gdbadmin@sourceware.org> wrote:
> 270a271
>> gdb/dwarf2loc.c:3431: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
> gdb/dwarf2loc.c:3431: ?else if (data + 3 <= end ? ?&& data + 1 + (leb128_size = skip_leb128 (data + 1, end)) < end ? ? ? ? && data[0] == DW_OP_GNU_const_index ? ? && leb128_size > 0 ? ? ?&& data[1 + leb128_size] == DW_OP_GNU_push_tls_address ? ? ? ? ?&& piece_end_p (data + 2 + leb128_size, end))

Blech.  Given the structure of the code that was already there, the
embedded assignment was a no-brainer.  In gcc-land they're not exactly
forbidden.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]