This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/python] notify memory changed.


On Thursday 21 June 2012 16:52:33 Abid, Hafiz wrote:
> > +/* Same as write_memory, but notify 'memory_changed' observers.  */
> > +
> > +void
> > +write_memory_with_notification (CORE_ADDR memaddr, const bfd_byte
> > *myaddr,
> > +                             ssize_t len)
> > +{
> > +  write_memory (memaddr, myaddr, len);
> > +  observer_notify_memory_changed (memaddr, len, myaddr);
> > +}
> > +
> 
> Do you think it will be useful to have parameters of
> observer_notify_memory_changed in same order as write_memory. When I looked
> at this code, I had to look at the function to make sure it was not a typo.

Hafiz,
I am not sure.  Both 'write_memory' and 'observer_notify_memory_changed' 
exists here for some years, and I guess people get use to them.

-- 
Yao Qi (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]