This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH 00/16] branch tracing support (resend)


> -----Original Message-----
> From: Metzger, Markus T
> Sent: Monday, June 25, 2012 10:50 AM

[...]

> > Markus>   - "btrace enable/disable" perform the obvious operation
> >
> > I think it may be more "gdb-ish" to make this a set/show option, by
> > analogy with "set stop-on-solib-events" and the like.
> >
> > This would give users a way to see whether it is currently enabled, as
> > well.
> 
> You mean something like "set btrace on"?

I looked at some other gdb commands with related behavior. Tracepoints uses tstart/tstop; record uses record/record stop. Record
uses set/show for configuration options.

By analogy, this could be used for configuring the size of the trace buffer. Or it could be used to turn automatic enabling on and
off.

Set typically changes some global setting, whereas the btrace enable/disable commands operate on the current thread or a range of
threads.

It might make sense to turn "btrace enable/disable auto" into "set btrace auto on/off". But I would leave the "btrace
enable/disable" commands, as they are - or maybe rename them into "btrace start/stop".

[...]

Regards,
markus.

Attachment: smime.p7s
Description: S/MIME cryptographic signature

--------------------------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland 
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]