This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA libiberty, gdb] Add hashtab support to filename_ncmp.c and use it in gdb.
- From: Tom Tromey <tromey at redhat dot com>
- To: dje at google dot com (Doug Evans)
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 10 Jul 2012 13:17:10 -0600
- Subject: Re: [RFA libiberty, gdb] Add hashtab support to filename_ncmp.c and use it in gdb.
- References: <20120709181407.213E81E13A1@ruffy2.mtv.corp.google.com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> filename_seen in gdb does a linear search, this patch changes it
Doug> to use a hash table.
Doug> Ok to check in?
The gdb parts look good to me.
Doug> I couldn't think of a good reason to put filename_hash,filename_eq
Doug> in gdb, and I like placing them close to where hashtab.c and
Doug> filename_cmp are defined. I also couldn't think of a sufficient
Doug> reason to put them in a file by themselves.
FWIW, I agree. I'd like to see this patch go in.
Tom