This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/6] attach to command_option-changed observer.
> From: Yao Qi <yao@codesourcery.com>
> Date: Wed, 25 Jul 2012 00:10:49 +0800
>
> This patch is to attach function 'mi_command_option_changed' to
> observer 'command_option_changed', so that a MI notification
> "=option-changed" is sent to MI frontend. If the command option
> change is requested from MI, the notification is suppressed.
Thanks.
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,11 @@
>
> *** Changes since GDB 7.5
>
> +* MI changes
> +
> + ** Command option changes are now notified using new async record
> + "=option-changed".
OK.
> +@item =option-changed,option=@var{command},value=@var{value}
> +Reports that an option of the command @var{set command} is changed
> +to @var{value}. ^^^^^^^^^^^^^^^^^
Please use "@code{set @var{command}}" instead of the underlined part.
Only COMMAND should be in @var, since "set" is a literal string.
Btw, it is better to use "option" instead of "command" in the above,
since that's what "set" does -- it changes values of user options.
The documentation parts are OK with those changes.