This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Cannot set pending bp if condition set explicitly

From: Tom Tromey <tromey at redhat dot com>
To: Marc Khouzam <marc dot khouzam at ericsson dot com>
Cc: "'gdb-patches\ at sourceware dot org'" <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
Date: Wed, 25 Jul 2012 14:43:48 -0600
Subject: Re: [Patch] Cannot set pending bp if condition set explicitly
References: <F7CE05678329534C957159168FA70DEC5C24CAEA18@EUSAACMS0703.eamcs.ericsson.se> <87zk6nkghi.fsf@fleche.redhat.com> <F7CE05678329534C957159168FA70DEC5C2500353F@EUSAACMS0703.eamcs.ericsson.se>

Marc> I took the original line from print_one_exception_catchpoint()
Marc> when it figures out to print <PENDING>.

Yeah, I'm just not sure that this test is definitive in all cases.

Marc> But I changed it to use all_locations_are_pending() in the below 
Marc> patch, and it also solves the problem I was seeing.

I'd like Pedro's input on this patch.  I CC'd him.

Marc> How does it look for HEAD and 7_5 (not the tests
Marc> for 7_5 I gather)?

I think it is fine to put a new test onto the release branch.
The worst that can happen is a new FAIL -- but it isn't like the test
case is 0-FAIL in normal circumstances anyway.

Tom

References:
- [Patch] Cannot set pending bp if condition set explicitly
  - From: Marc Khouzam
- Re: [Patch] Cannot set pending bp if condition set explicitly
  - From: Tom Tromey
- RE: [Patch] Cannot set pending bp if condition set explicitly
  - From: Marc Khouzam

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]