This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 2/5] Explicit linespecs - breakpoint API


On Fri, 27 Jul 2012 05:47:28 +0200, Keith Seitz wrote:
> +static int
> +create_breakpoint_1 (struct gdbarch *gdbarch,
> +		     struct linespec_result *canonical, char *arg,
> +		     char *cond_string, int thread, char *extra_string,
> +		     int parse_condition_and_thread,
> +		     int tempflag, enum bptype type_wanted, int ignore_count,
> +		     enum auto_boolean pending_break_support,
> +		     const struct breakpoint_ops *ops,
> +		     int from_tty, int enabled, int internal, int flags)
>  {
[...]
> +  /* Anything added to the cleanup chain is assumed to be part of a
> +     breakpoint.  If the breakpoint create succeeds then the memory is
> +     not reclaimed.  */
> +  bkpt_chain = make_cleanup (null_cleanup, 0);

It is NULL, not 0.


[...]
> -static void create_sals_from_address_default (char **,
> +static void create_sals_from_address_default (explicit_linespec *, char **,
>  					      struct linespec_result *,
>  					      enum bptype, char *,
>  					      char **);
[...]
> --- a/gdb/linespec.h
> +++ b/gdb/linespec.h
> @@ -53,6 +53,27 @@ struct linespec_sals
>  typedef struct linespec_sals linespec_sals;
>  DEF_VEC_O (linespec_sals);
>  
> +/* A description of an explicit linespec.  */
> +
> +struct explicit_linespec
> +{
[...]
> +};
> +typedef struct explicit_linespec explicit_linespec;

The current GDB style AFAIK still does not use such typedefs.  It is struct,
so it should be called 'struct explicit_linespec'.



Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]