This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] DWARF frame unwinder executes one too many rows
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 30 Jul 2012 11:43:19 -0600
- Subject: Re: [RFA] DWARF frame unwinder executes one too many rows
- References: <1343343082-15401-1-git-send-email-brobecker@adacore.com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> gdb/ChangeLog:
Joel> * dwarf2-frame.c (dwarf2_frame_cache): Use
Joel> get_frame_address_in_block instead of get_frame_pc as
Joel> the bound for executing the frame's FDE.
Joel> gdb/testsuite/ChangeLog:
Joel> * gdb.ada/rdv_wait: New testcase.
This looks good to me.
I looked into the history a tiny bit. It appears I introduced this in
revision 1.120, but looking at the diff it appears I just hoisted the
call to get_frame_pc out of execute_cfa_program. Whew.
Before that it gets into stuff before my involvement:
- CORE_ADDR pc = frame_pc_unwind (next_frame);
+ CORE_ADDR pc = get_frame_pc (this_frame);
Tom