This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/9] use the BFD cache
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 31 Jul 2012 17:23:25 +0100
- Subject: Re: [PATCH 7/9] use the BFD cache
- References: <871ujt5l38.fsf@fleche.redhat.com>
On 07/30/2012 04:23 PM, Tom Tromey wrote:
> @@ -748,9 +748,9 @@ add_vmap (LdInfo *ldi)
> if (fd < 0)
> /* Note that this opens it once for every member; a possible
> enhancement would be to only open it once for every object. */
> - abfd = gdb_bfd_openr (filename, gnutarget);
> + abfd = gdb_bfd_open (filename, gnutarget, -1);
> else
> - abfd = gdb_bfd_fdopenr (filename, gnutarget, fd);
> + abfd = gdb_bfd_open (filename, gnutarget, fd);
Looks like both paths could be consolidated into a single call (and maybe
the comment is outdated by the cache), but I'll understand if you want to
keep it as is.
--
Pedro Alves