This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix UNOP_CAST_TYPE, UNOP_MEMVAL_TYPE, et. al.
- From: Tom Tromey <tromey at redhat dot com>
- To: dje at google dot com
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 08 Aug 2012 12:15:19 -0600
- Subject: Re: [RFA] Fix UNOP_CAST_TYPE, UNOP_MEMVAL_TYPE, et. al.
- References: <yjt2lihrk4an.fsf@ruffy2.mtv.corp.google.com>
>>>>> "Douglas" == Douglas Evans <dje@google.com> writes:
Doug> While working on another patch I found gdb crashing on "p
Doug> {char[4]} foo". Using "set debug expression 1" I then found
Doug> gdb rejecting valid expressions.
Doug> This patch fixes the issues I found.
Thanks.
Doug> I also wonder about adding tests for "set debug expression 1",
Doug> but they make it easy to repro the problem so I've included them here.
I think it is a good idea. For one thing we can require new tests like
this for future opcode additions, making gdb more robust.
The possible downside seems to be if we want to change the debug output
or the expression representation. But, the former has to be considered
pretty rare given the history, and for the latter it is fine to just
nuke or modify the tests as appropriate.
Doug> Ok to check in?
Looks good to me.
Tom