Re: [PATCH] Don't attach to 'target_changed' observer in regcache

[Yao Qi <yao at codesourcery dot com>]

On Wednesday, August 08, 2012 07:53:40 PM Mark Kettenis wrote:
> > The author (Orjan) tried to support "changing the bank select register
> > changes the contents (and meaning) for a whole set of other registers."
> > The requirement is quite specific to Orjan's own port, so the better
> > solution is to attach a function which invalidates all regcache in
> > Orjan's backend, instead of doing it in target-independent part.
> 
> Banked registers aren't really that exotic.  Especially if you realise
> that register windows (SPARC, IA-64) are essentially banked registers.
> 

Banked register doesn't matter here.  "Changing one special register changes 
the whole set of registers", which is exotic, matters.  Are they (banked 
registers) switched by modifying a certain register?  Per my few knowledge on 
SPARC and IA-64, the answer is "No".

The issues of this patch are 1) modifying read-only bits in writable register 
(as Dan pointed out), 2) troubles to Orjan's port.  I can't see any other 
issues of this patch.

-- 
Yao (éå)