This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFC: merged python exception handling patch

From: Tom Tromey <tromey at redhat dot com>
To: Doug Evans <dje at google dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 13 Aug 2012 13:42:49 -0600
Subject: Re: RFC: merged python exception handling patch
References: <878vdma5zp.fsf@fleche.redhat.com> <CADPb22RxkquDkjpo0iV7ZY13XtjPqbG9L-cbmon1z6vEP-U77Q@mail.gmail.com> <871uja7jrc.fsf@fleche.redhat.com> <CADPb22QhrFs1EDa1S0CnQNGCW2AeCg-niumoy7ZErNfmB_irfw@mail.gmail.com>

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> I think the function comment needs to point out that quit_flag is reset.
Doug> [I realize the comment at the declaration says this.]

We have a general policy against comment duplication like this though.

Doug> Also, I think you need to temporarily block SIGINT between fetching
Doug> quit_flag and resetting it.

I will look into it.

Tom

References:
- RFC: merged python exception handling patch
  - From: Tom Tromey
- Re: RFC: merged python exception handling patch
  - From: Doug Evans
- Re: RFC: merged python exception handling patch
  - From: Tom Tromey
- Re: RFC: merged python exception handling patch
  - From: Doug Evans

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]