This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: GDB 7.5: Problems with the auto-load safe-path feature
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 18 Aug 2012 20:07:49 +0300
- Subject: Re: GDB 7.5: Problems with the auto-load safe-path feature
- References: <83d32ogz3g.fsf@gnu.org> <20120818161049.GI2798@adacore.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Sat, 18 Aug 2012 09:10:49 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> > This new feature in GDB 7.5 looks like a nuisance in my (short)
> > experience.
>
> Same here. Very very much agreed, in fact. But I don't feel we have
> much of a leg to stand on, when opposing the feature. Jan and I
> discussed this feature quite a bit, as I recall, and came to the best
> compromise we could.
Let's see what the users at large say about this.
> For your own personal purposes, you can turn this feature off by
> default when configuring GDB. I think that the configure option is:
> --without-auto-load-safe-path
It's easier to do that in ~/.gdbinit.
> > 2012-08-18 Eli Zaretskii <eliz@gnu.org>
> >
> > * auto-load.c (auto_load_objfile_script): If OBJFILE specifies a
> > DOS/Windows-style .exe executable program, remove the .exe suffix
> > when generating the script file name.
>
> I think that the test should ideally be target-dependent. But short of
> that, how about we just try without the .exe prefix if the first attempt
> failed, regardless of host and/or target?
Like in the patch below? I can drop the #ifdef, if no one objects (it
could surprise Unix users who call their programs FOO.exe for some
reason).
--- gdb/auto-load.c~ 2012-08-18 15:47:48.953125000 +0300
+++ gdb/auto-load.c 2012-08-18 19:44:20.859375000 +0300
@@ -708,20 +708,6 @@ auto_load_objfile_script (struct objfile
@@ -735,6 +721,29 @@ auto_load_objfile_script (struct objfile
fprintf_unfiltered (gdb_stdlog, _("auto-load: Attempted file \"%s\" %s.\n"),
debugfile, input ? _("exists") : _("does not exist"));
+#if defined (__MSDOS__) || defined (__MINGW32__)
+ /* For Windows/DOS .exe executables, strip the .exe suffix, so that
+ FOO-gdb.gdb could be used for FOO.exe, and try again. */
+ if (!input)
+ {
+ const size_t lexe = sizeof (".exe") - 1;
+
+ if (len > lexe
+ && strcasecmp (realname + len - lexe, ".exe") == 0)
+ {
+ len -= lexe;
+ realname[len] = '\0';
+ filename = xrealloc (filename, len + strlen (language->suffix) + 1);
+ memcpy (filename, realname, len);
+ strcpy (filename + len, language->suffix);
+ input = fopen (filename, "r");
+ debugfile = filename;
+ if (debug_auto_load)
+ fprintf_unfiltered (gdb_stdlog, _("auto-load: Attempted file \"%s\" %s.\n"),
+ debugfile, input ? _("exists") : _("does not exist"));
+ }
+ }
+#endif
if (!input)
{
VEC (char_ptr) *vec;