This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: AIX 64bit support


> Let me know if we can do #ifdef check in a macro and call the marco as
> mentioned below would be feasible to reduce the many #ifdef checks ?
> 
> 
> macro for ptrace64aix
> 
> #define ptrace_check_64aix(req, tid, addr, data, buff) \
>     #ifdef BFD64 \
>     if (!ptrace64aix (req, (long long) tid, \
>                      (long long) addr, data, buff)) \
>      #else \
>     if (!ptrace64aix (req, tid, \
>  			    (unsigned long) addr, data, buff)) \
>     #endif \

Can you please instead make those functions instead? It will make
the code much easier to understand, IMO.


-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]