This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] info threads sort by name and name regex matching


> Date: Tue, 21 Aug 2012 14:18:42 -0700
> From: Aaron Gamble <agamble@google.com>
> 
> Here is a patch for adding sorting by name in 'info threads' and regex
> pattern matching of thread names for filtering threads.

Thanks.

> Regex matching is specified by doing 'info threads r<regex>'. This is
> not ambiguous with previous behavior where parameters to info threads
> were only numbers. (spaces between 'r' and <regex> are ignored)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be documented in the manual.

> +@item info threads @r{[}@var{id}@dots{}@b{|}r<@var{regex}>@r{]}

No need for <...> around "regex", the @var markup does the equivalent
already.

> +Display a summary of all threads currently in your program.  Optional
> +argument for specifying threads is either @code{r} followed by a regular
> +expression or @var{id}@dots{} one or more numeric thread ids separated by
                               ^^^
Something's missing here, perhaps "for" or an em-dash "---".

> +spaces. The list of threads is sorted alphabetically by thread name.
         ^^
Two spaces between sentences, please.

The documentation part is OK with these changes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]