This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] include libiberty.h in gdbserver.h
- From: Doug Evans <dje at google dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 22 Aug 2012 15:34:17 -0700
- Subject: Re: [PATCH] include libiberty.h in gdbserver.h
- References: <1345639574-18805-1-git-send-email-yao@codesourcery.com>
On Wed, Aug 22, 2012 at 5:46 AM, Yao Qi <yao@codesourcery.com> wrote:
> Hi,
> Some macros have been defined in libiberty.h and ansidecl.h, but we
> define them again in server.h. libiberty.h has been included in
> gdbserver, so I think we can use the macros defined in 'libiberty.h' and
> 'ansidecl.h' in gdbserver. so this patch is to include them, and
> remove these macros in server.h.
>
> Rebuild GDBserver for x86-linux and mingw32. OK to apply?
>
> gdb/gdbserver:
>
> 2012-08-22 Yao Qi <yao@codesourcery.com>
>
> * ax.c, tracepoint.c: Replace ATTR_FORMAT with ATTRIBUTE_PRINTF.
> * server.h: Include 'libiberty.h' and 'ansidecl.h'.
> Remove macro ATTR_NORETURN, ATTR_FORMAT, and ATTR_MALLOC.
> Remove declarations of xmalloc, xreallloc, xstrdup and
> freeargv.
> Replace ATTR_NORETURN with ATTRIBUTE_NORETURN.
> Replace ATTR_FORMAT with ATTRIBUTE_PRINTF.
The patch is ok with me, though I'd wait a few days to see if someone
else has an opinion.
Then changelog entry does not follow convention though. Please fix.
E.g., generally we put the name of the object affected in parens.
As in,
(ATTR_NORETURN): Delete.