This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Set $trace_frame and $tracepoint on disconnect
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 23 Aug 2012 09:46:37 -0600
- Subject: Re: [PATCH] Set $trace_frame and $tracepoint on disconnect
- References: <1345550573-24752-1-git-send-email-yao@codesourcery.com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> The chunk for tracepoint.c is to set these variables correctly
Yao> when GDB disconnects and some small refactors in code.
Yao> Regression tested on x86_64-linux, two fails above are fixed.
Yao> OK to apply?
Looks good to me.
I read your patch and traced through the various tracepoint.c functions.
Just a side note on tracepoint.c - it seems bad to have functions named
"set_traceframe_num" and "set_traceframe_number" with different effects.
A bit of reading showed me what was going on, but the names seem
needlessly confusing.
Tom