This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] include libiberty.h in gdbserver.h
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 24 Aug 2012 18:16:11 +0100
- Subject: Re: [PATCH] include libiberty.h in gdbserver.h
- References: <1345639574-18805-1-git-send-email-yao@codesourcery.com>
On 08/22/2012 01:46 PM, Yao Qi wrote:
> Hi,
> Some macros have been defined in libiberty.h and ansidecl.h, but we
> define them again in server.h. libiberty.h has been included in
> gdbserver, so I think we can use the macros defined in 'libiberty.h' and
> 'ansidecl.h' in gdbserver. so this patch is to include them, and
> remove these macros in server.h.
Makes me a little nervous (the current use of bits of libiberty in
gdbserver is already a hack, and this spreads it), but okay.
Don't we need to update Makefile dependencies to make $server_h
depend on ...include/libiberty.h and ...include/ansidecl.h ?
--
Pedro Alves