This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] de-couple %Stop from notification: gdb
Yao Qi writes:
> This patch is to de-couple vStopped/%Stop from notification in gdb side.
Hi. Just a few nits, maybe more to follow.
> gdb:
>
> 2012-08-24 Yao Qi <yao@codesourcery.com>
>
> (struct remote_state): Move to remote.h.
What's the reason for moving struct remote_state to remote.h?
[I did a simple grep and couldn't find a reason, I could have missing something of course.]
Having it live in remote.c means the implementation is "private" to just that file.
> diff --git a/gdb/remote-notif.c b/gdb/remote-notif.c
> new file mode 100644
> index 0000000..ca7f821
> --- /dev/null
> +++ b/gdb/remote-notif.c
> @@ -0,0 +1,285 @@
> [...]
> +
> +extern struct remote_state *get_remote_state (void);
Don't declare external functions in .c files, it should live in a header.