Re: [PATCH 2/2] Remove pass in skip_unwinder_tests

[Yao Qi <yao at codesourcery dot com>]

On 08/27/2012 09:06 PM, Jan Kratochvil wrote:
> > If we do a gdb test, and test is failed because of the misbehaviour,
> > >we should use XFAIL.
> What is "misbehavior" here?

I meant "system misbehaviour".

> > >However, in proc 'skip_XXX' in lib/gdb.exp, we
> > >check the supported feature of system instead of doing a gdb test,
> > >so no PASS/FAIL/XFAIL should be emitted.
> XFAIL is for "unsupported system feature".
>
> What does XFAIL mean different than "unsupported system feature"?

IMO, XFAIL means "unsupported system feature" or "system misbehaviour" 
in my previous reply, but ...

> When will ever be XFAIL emitted if not for "unsupported system feature"?

... it doesn't mean we should use XFAIL for *every* "unsupported system 
feature", IMO.  XFAIL can be used for "unsupported system feature" in 
gdb test, but XFAIL (nor PASS) can not be used in checking the feature 
of system, because checking itself is not a test.  I'd like to call them 
(proc skip_XXX and proc support_XXX in lib/gdb.exp) 'test configuration 
checking' which determines the set of tests to run according to the 
configuration of GDB and other factors.  They should not contribute 
PASS/XFAIL/FAIL/... to test result, because they are not tests.

--
Yao