This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] suppress notification
On 08/28/2012 02:49 PM, Yao Qi wrote:
> On 08/28/2012 09:39 PM, Pedro Alves wrote:
>>
>> Alternatively, set the notification suppression down in the command callback itself.
>> I mention it for completeness. Maybe you've considered it, and decided against it.
>>
>
> Are you suggesting that we can set breakpoint suppression flag in each breakpoint related CLI commands, such as "delete breakpoint", "disable breakpoint", and so forth?
Not really a strong suggestion, but more like it seemed like the obvious
first choice to me, so I wondered if you considered and discarded it.
You wouldn't do it within the CLI commands. Instead you'd expand:
{ "break-delete", { "delete breakpoint", 1 }, NULL },
into something like
{ "break-delete", { NULL, 0 }, mi_cmd_break_delete },
and then mi_cmd_break_delete would suppress the notification and
call "delete breakpoint" itself. Or a core API function to break
the CLI dependency (which might be a good idea anyway).
--
Pedro Alves