RE: [RFC] New GDB Port CR16

[Kaushik Phatak <Kaushik dot Phatak at kpitcummins dot com>]

Hi Mike,Yao,
Thanks for all your comments. 

> might be nice if you were to split them up and commit them separately
I have attached an updated patch with purely sim port related changes.
The patch changes the following files in gdb-sim
/sim/common/gennltvals.sh
/sim/common/nltvals.def
/sim/cr16/cr16_sim.h
/sim/cr16/interp.c
/sim/cr16/simops.c

I have tried to address the other points as follows,

> but that should be "(void)".  i imagine this sim port probably has 
> a bunch of those bugs lurking though.
Yes, but I have not tinkered with this as yet.

> pretty sure the indentation here is incorrect. 
My mistake. This was a switch inside a switch and my case statements were
aligned with the first level case statements. This is now fixed.

> please do not use C++ style comments
This is now fixed.

> this new local prototype makes no sense.  just delete it.
OK. I will create separate binutils patch with these changes and submit it
to binutils at sourceware dot org as per Yao Qi's suggestion.

> The changes for top-level configure stuff should be submitted to 
> gcc-patches with changelog entry.
Thanks Yao for these patch submission tips. 


2012-08-28 Kaushik Phatak  <kaushik.phatak@kpitcummins.com>

sim/common/
	* gennltvals.sh: Use libgloss/syscall.h for cr16.
	* nltvals.def: Regenerate.
sim/cr16/ChangeLog:
	* interp.c (sim_complete_command): New stub function.
	* cr16_sim.h : Add defines for TRAP handling.
	* simops.c: Breakpoint handling code.

Thanks & Best Regards,
Kaushik
kaushik.phatak@kpitcummins.com
KPIT Cummins Infosystems Ltd
www.kpitcummins.com

Attachment: cr16_sim.diff
Description: cr16_sim.diff