This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Bug win32/14529] Make gdb capable of JIT-debugging on W32
- From: Tom Tromey <tromey at redhat dot com>
- To: LRN <lrn1986 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 10 Sep 2012 12:15:23 -0600
- Subject: Re: [Bug win32/14529] Make gdb capable of JIT-debugging on W32
- References: <503E575D.1000608@gmail.com> <83y5kvp0za.fsf@gnu.org> <5040DA38.2070802@gmail.com> <504D4EE1.5010507@gmail.com>
>>>>> "LRN" == LRN <lrn1986@gmail.com> writes:
LRN> diff --git a/gdb/infcmd.c b/gdb/infcmd.c
[...]
LRN> +#if W32_JITDBG
LRN> +void
LRN> +signal_event_command (char *args, int from_tty)
LRN> +{
Two notes here.
First, does it make sense to put this in windows-nat.c instead?
(I don't know anything about the Windows port...)
It doesn't matter hugely.
Second, it is odd to call this a _command and give it the above
prototype. Normally this convention is used for things which are really
commands -- visible to the user from the gdb CLI.
I suppose this is so you can use catch_command_errors; but it seems like
you could equally well use catch_errors.
LRN> + struct cleanup *back_to = make_cleanup (null_cleanup, NULL);
You don't need a null cleanup unless you plan to make other cleanups.
But AFAICT there aren't any.
LRN> + dont_repeat (); /* Not for the faint of heart */
You only need this for a real command.
Tom