This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Merge mi-cli.exp and mi2-cli.exp


On 09/11/2012 10:53 PM, Stan Shebs wrote:

>> But more than that, in reality, we stopped supporting MI1 almost 10 years ago:
>>
>>   http://sourceware.org/ml/gdb-patches/2004-02/msg00352.html
> 
> That's a good point, seemed like it was just yesterday. :-)  A little poking around the net shows that it's been quite a while since anybody has used MI1.

:-)

> 
>> So my opinion is that we revisit the policy a bit, and backtrack a the
>> mi-.*exp vs mi2-.*exp idea, get rid of the duplication, and call everything
>> "MI2", as it is in practice (must be, because that's how we run the tests).
>> When we really introduce an incompatible change that actually justifies MI3,
>> _then_ we should revisit the policy of whether to mass copying/rename tests, or
>> share them, depending on how big the difference between the versions would be,
>> and therefore depending on the practicality of the different options.
>>
> 
> Sounds like a fine idea - and MI1 has already been deprecated for a long time, so we can just whack things now.

To be clear, there's no MI1 test in the suite anymore.  What we have is
explicit -i=mi2 tests, and -i=mi tests.  One of the sets was copied from
the other, with the idea that we'd fork them and while breaking
compatibility with MI2, and that -i=mi would then be switched to mean MI3.
But that never happened.  The -i=mi tests still test the same MI2.  So we now test
the same things twice, due to the tests having been copied prematurely.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]