This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] uprobes: add global breakpoints
- From: Oleg Nesterov <oleg at redhat dot com>
- To: Sebastian Andrzej Siewior <bigeasy at linutronix dot de>
- Cc: srikar at linux dot vnet dot ibm dot com, Ingo Molnar <mingo at elte dot hu>, Peter Zijlstra <peterz at infradead dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Roland McGrath <roland at hack dot frob dot com>, linux-kernel at vger dot kernel dot org, gdb-patches at sourceware dot org
- Date: Wed, 12 Sep 2012 20:12:10 +0200
- Subject: Re: [PATCH 2/2] uprobes: add global breakpoints
- References: <1347377843-16017-1-git-send-email-bigeasy@linutronix.de> <1347377843-16017-2-git-send-email-bigeasy@linutronix.de> <20120912143010.GA1447@redhat.com>
On 09/12, Oleg Nesterov wrote:
>
> Lets start with the patch below,
> ...
>
> - if (!(uprobe->flags & UPROBE_SKIP_SSTEP))
> + if (!(uprobe->flags & UPROBE_SKIP_SSTEP) || (action & UPROBE_RESTART))
Hmm. This is wrong, but only because handle_swbp() is buggy.
I'll send the fix tomorrow.
Oleg.