This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[doc ping] for: Write bpt at the ON_STACK bpt address
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Eli Zaretskii <eliz at gnu dot org>
- Date: Thu, 13 Sep 2012 07:50:17 +0200
- Subject: [doc ping] for: Write bpt at the ON_STACK bpt address
Hi Eli,
the gdb/doc/ part remains not committed.
The patch was the gdb/doc/ part of:
http://sourceware.org/ml/gdb-patches/2012-07/msg00706.html
your review:
http://sourceware.org/ml/gdb-patches/2012-07/msg00717.html
my reply to the review:
http://sourceware.org/ml/gdb-patches/2012-07/msg00718.html
I did not use your rewording of the first paragraph as explained in the last
mail referenced above.
Thanks,
Jan
gdb/doc/
2012-09-13 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdbint.texinfo (Defining Other Architecture Features): Clarify *pcptr
encoding for gdbarch_breakpoint_from_pc, bp_addr for
gdbarch_push_dummy_call and bp_addr for gdbarch_push_dummy_code.
diff --git a/gdb/doc/gdbint.texinfo b/gdb/doc/gdbint.texinfo
index 0749319..ee70bfa 100644
--- a/gdb/doc/gdbint.texinfo
+++ b/gdb/doc/gdbint.texinfo
@@ -4532,8 +4532,10 @@ contents and size of a breakpoint instruction. It returns a pointer to
a static string of bytes that encode a breakpoint instruction, stores the
length of the string to @code{*@var{lenptr}}, and adjusts the program
counter (if necessary) to point to the actual memory location where the
-breakpoint should be inserted. May return @code{NULL} to indicate that
-software breakpoints are not supported.
+breakpoint should be inserted. On input, the program counter
+(@code{*@var{pcptr}} is encoded like the inferior's PC register, on output it
+is encoded as a plain address. Function may return @code{NULL} to indicate
+that software breakpoints are not supported.
Although it is common to use a trap instruction for a breakpoint, it's
not required; for instance, the bit pattern could be an invalid
@@ -4813,7 +4815,7 @@ instead of value.
@anchor{gdbarch_push_dummy_call} Define this to push the dummy frame's call to
the inferior function onto the stack. In addition to pushing @var{nargs}, the
code should push @var{struct_addr} (when @var{struct_return} is non-zero), and
-the return address (@var{bp_addr}).
+the return address (@var{bp_addr}, in inferior's PC register encoding).
@var{function} is a pointer to a @code{struct value}; on architectures that use
function descriptors, this contains the function descriptor value.
@@ -4827,12 +4829,14 @@ instruction sequence (including space for a breakpoint) to which the
called function should return.
Set @var{bp_addr} to the address at which the breakpoint instruction
-should be inserted, @var{real_pc} to the resume address when starting
-the call sequence, and return the updated inner-most stack address.
+should be inserted (in inferior's PC register encoding), @var{real_pc} to the
+resume address when starting the call sequence, and return the updated
+inner-most stack address.
By default, the stack is grown sufficient to hold a frame-aligned
(@pxref{frame_align}) breakpoint, @var{bp_addr} is set to the address
-reserved for that breakpoint, and @var{real_pc} set to @var{funaddr}.
+reserved for that breakpoint (in inferior's PC register encoding), and
+@var{real_pc} set to @var{funaddr}.
This method replaces @w{@code{gdbarch_call_dummy_location (@var{gdbarch})}}.