This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch+7.5?] Fix GDB-return into TAILCALL_FRAME (PR 14119)


>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> I am not completely sure the patch in skip_inlined_frames is
Jan> appropriate for all the callers of skip_inlined_frames but it seems
Jan> so to me, frame_id of TAILCALL_FRAME is artifical the same way like
Jan> INLINE_FRAME is.

This argument is persuasive, but the patch still makes me a bit nervous,
just because the concrete details at each call point may matter.

It seems some comments need updating, e.g., inline_depth is overloaded
but the comment doesn't indicate this.

Jan> No regressions on {x86_64,x86_64-m32,i686}-fedora18-linux-gnu.
Jan> I would think this should be even for 7.5.

Me too.  I'm inclined to say it should go in.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]