This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)

From: Tom Tromey <tromey at redhat dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: Doug Evans <dje at google dot com>, Vasyl Vavrychuk <vvavrychuk at gmail dot com>, gdb-patches at sourceware dot org
Date: Mon, 17 Sep 2012 13:52:08 -0600
Subject: Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)
References: <CAGj4m+4au-jiC2ueSyC+wEY76YRQ5zNuxfY+-mfZ39N4fnpN_g@mail.gmail.com> <20120916080035.GA28890@host2.jankratochvil.net> <CAGj4m+46oBXSYQ-wx9g-P7yevZeMDnNNEjvADE8sRSdoWaRiVA@mail.gmail.com> <20120917062647.GA2514@host2.jankratochvil.net> <CAGj4m+6jZD=jg1MGD0NRmGXGgrOSW0FK9H7pSxYd4RLxLgfcsQ@mail.gmail.com> <20120917152938.GA22356@host2.jankratochvil.net> <CADPb22StZm5T_ULmQkqZO6ny1hkZM_oX0XrqxSOzqS=VM+tJ6Q@mail.gmail.com> <20120917161252.GA24333@host2.jankratochvil.net>

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan>  		|	OPERATOR DELETE
Jan> -			{ $$ = make_operator ("delete ", 1); }
Jan> +			{
Jan> +			  /* Match the whitespacing of cplus_demangle_operators.
Jan> + It would abort on unrecognized string otherwise.  */

The indentation here (and elsewhere) seems funny.

Jan> +set executable ${testfile}

This line shouldn't be needed.

I think the rest is fine though.

Tom

Follow-Ups:
- Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)
  - From: Jan Kratochvil

References:
- [patch] Fix internal error on canonicalization of clang types [Re: why in cplus_demangle_operators operation sizeof is expected to be followed with space]
  - From: Jan Kratochvil
- Re: [patch] Fix internal error on canonicalization of clang types [Re: why in cplus_demangle_operators operation sizeof is expected to be followed with space]
  - From: Vasyl Vavrychuk
- Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)
  - From: Jan Kratochvil
- Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)
  - From: Doug Evans
- Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]