This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] wrong language used when re-setting breakpoint


Joel> I kind of agree, but ... at the same time, this type of changes then
Joel> makes it harder for us to make progress in getting rid of the
Joel> current_language global, no?

Nope, sorry, what I'm suggesting is diagnosing and fixing this problem
first, then putting your patch in subsequently.

Joel> Also, I think that relying on the global being set for a defined period
Joel> of time is a little risky. It seems too easy for the current_language
Joel> to change right from under us as a side-effect of some sub-action.

Yes, I agree, and I think that's why the direction linespec is headed is
a good one.  But, temporarily setting current_language is how gdb has
worked for a long time, and if that broke, it probably means a
regression or bug elsewhere.  And, linespec isn't actually fully
parameterized like this anyway.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]