This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)


On Fri, 21 Sep 2012 21:39:54 +0200, Tom Tromey wrote:
> At least from the patch it appears that the comment is over by the
> leftmost column, but I think the comment should be indented like the
> code is.

This is after patch from the mail, grep -3 xxx | expand, inserted into this
mail.

I see it has 81 columns but with the large tabs there this file has very
common violation of > 80 columns; I can fix this patch, though.


Thanks,
Jan


------------------------------------------------------------------------------

operator        :       OPERATOR NEW
                        {
                          /* Match the whitespacing of cplus_demangle_operators.
                             It would abort on unrecognized string otherwise.  */
                          $$ = make_operator ("new", 3);
                        }
                |       OPERATOR DELETE
                        {
                          /* Match the whitespacing of cplus_demangle_operators.
                             It would abort on unrecognized string otherwise.  */
                          $$ = make_operator ("delete ", 1);
                        }
                |       OPERATOR NEW '[' ']'
                        {
                          /* Match the whitespacing of cplus_demangle_operators.
                             It would abort on unrecognized string otherwise.  */
                          $$ = make_operator ("new[]", 3);
                        }
                |       OPERATOR DELETE '[' ']'
                        {
                          /* Match the whitespacing of cplus_demangle_operators.
                             It would abort on unrecognized string otherwise.  */
                          $$ = make_operator ("delete[] ", 1);
                        }
--

exp     :       SIZEOF '(' type ')'     %prec UNARY
                {
                  /* Match the whitespacing of cplus_demangle_operators.
                     It would abort on unrecognized string otherwise.  */
                  $$ = d_unary ("sizeof ", $3);
                }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]