This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Eliminate local variables to use TYPE_LENGTH directly


On Tue, 25 Sep 2012 22:27:44 +0200, Tom Tromey wrote:
> Jan> While correct I find this expression too tricky, check_typedef should be
> Jan> called rather ahead of some block of code later depending on it.
> 
> I often think we should have TYPE_LENGTH call check_typedef invisibly.
> The current situation seems error-prone.

It can be very expensive, one should benchmark it.  Also in some situations
during DWARF reading it may not be safe to call check_typedef (although
check_typedef already looks at CURRENTLY_READING_SYMTAB so it may work).

Anyway it is outside of the scope of Siddhesh's patch.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]