This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] AArch64 Port of GDB and GDBSERVER
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Marcus Shawcroft <marcus dot shawcroft at arm dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 24 Oct 2012 10:00:49 +0100
- Subject: Re: [PATCH] AArch64 Port of GDB and GDBSERVER
- References: <5062CCF0.5050203@arm.com> <50758B15.4040207@arm.com> <20121023151503.GC3555@adacore.com>
On 23 October 2012 16:15, Joel Brobecker <brobecker@adacore.com> wrote:
> Marcus,
>
> I started reviewing your patch before I eventually realized that your
> patch is 6500 lines long. So far, I reviewed Makefile.in (OK), and
> aarch64-linux-nat.c (comments below). I've stopped, because this is
> A LOT of code, and very time consuming.
>
> Can I please suggest that you split your patch in manageable (and
> independent!) chunks?
Joel, Thanks for the feedback. I'll deal with your initial comments
and re-submit a set of small patches as suggested.
Thanks
/Marcus