Re: [PATCH 2/2] new tracepoint downloaded MI notification.

[Pedro Alves <palves at redhat dot com>]

On 10/15/2012 07:03 PM, dje@google.com wrote:
> Yao Qi writes:
>  > Hi,
>  > This patch is to add a new MI notification to MI front-end when
>  > tracepoints are downloaded to target.
>  > 
>  > gdb:
>  > 
>  > 2012-09-27  Yao Qi  <yao@codesourcery.com>
>  > 
>  > 	* target.c: Include "observer.h".
>  > 	(target_download_tracepoint): New.
>  > 	* target.h (target_download_tracepoint): Remoe macro.
>  > 	Declare target_download_tracepoint.
>  > 	* mi/mi-interp.c (mi_interpreter_init):
>  > 	(mi_tracepoint_downloaded): New.
>  > 	* observer.sh (struct bp_location): Forward declaration.
>  > 
>  > 	* NEWS: Mention it.
>  > 
>  > gdb/doc:
>  > 
>  > 2012-09-27  Yao Qi  <yao@codesourcery.com>
>  > 
>  > 	* observer.texi (GDB Observers): New observer
>  > 	'tracepoint-downloaded'.
>  > 	* gdb.texinfo (GDB/MI Async Records): Document for MI notification
>  > 	"=tracepoint-downloaded".
>  > 
>  > gdb/testsuite:
>  > 
>  > 2012-09-27  Yao Qi  <yao@codesourcery.com>
>  > 
>  > 	* gdb.trace/mi-traceframe-changed.exp (test_tfind_remote): Adjust.
>  > 	* gdb.trace/mi-tracepoint-downloaded.exp: New.
> 
> Hi.
> It would be useful if the reason why this notification exists was specified in the code.
> E.g, "This notification exists because frontends ... [fill in the blank]."

Yes, indeed.  I'll probably upgrade that "useful" to "required".  :-)
It is not clear for example, why would the frontend
care about a particular tracepoint having been downloaded.  I can see
it wanting to know when a trace run has started from the CLI, for instance,
which already implies that tracepoints have been downloaded.

-- 
Pedro Alves