This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove printf from gdb.threads/manythreads.c


On 11/01/2012 08:27 AM, Yao Qi wrote:
> Hi,
> When debugging a fail in manythreads.exp, I find manythreads prints
> many lines that make the gdb.log unreadable.  It is useless to print
> something in inferior because the output is invisible to dejagnu when
> doing remote testing with gdbserver.  It is also improper to match
> inferior's output in manythreads.exp.  This patch is to remove the
> printf in manythreads.c and don't match its output in manythreads.exp.
> 

I looked for the history of the test, and it seems like this doesn't
decrease the testing scope (*).  So fine with me.

(*) - http://sourceware.org/ml/gdb-patches/2004-03/msg00685.html

Seems like you're only removing one instance of "Thread ... executing" in the
.exp file, but I see at least two more.

Okay with that change.  Or since all the thread id array, the argument
passing to thread_function etc., are all still in place, and I think that
if I were to investigate/debug a failure in this test, I'd add the printf
back temporarily, we could leave it there commented out (or enabled with a
command line option).

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]