This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Always include defs.h first.


On 11/08/2012 05:04 PM, Pierre Muller wrote:
>   Hi Pedro,
> 
>   I think you missed the python subdirectory...
> $ grep \"defs\.h\" */*.h
> python/py-event.h:#include "defs.h"
> python/py-events.h:#include "defs.h"

Indeed I have.

> The C sources also do not all include defs.h ...

Yeah.  They're getting it from those headers.  IMO, this makes it
easy to forget about it, and risk some change adding the inclusion
of a system header before including py-events.h, etc.  But since
we don't have consensus, I'll leave it at that.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]