This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Always include defs.h first.
- From: Pedro Alves <palves at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 08 Nov 2012 17:16:35 +0000
- Subject: Re: [PATCH] Always include defs.h first.
- References: <20121107201107.25258.47267.stgit@brno.lan> <000301cdbdd3$1b0f7780$512e6680$@muller@ics-cnrs.unistra.fr>
On 11/08/2012 05:04 PM, Pierre Muller wrote:
> Hi Pedro,
>
> I think you missed the python subdirectory...
> $ grep \"defs\.h\" */*.h
> python/py-event.h:#include "defs.h"
> python/py-events.h:#include "defs.h"
Indeed I have.
> The C sources also do not all include defs.h ...
Yeah. They're getting it from those headers. IMO, this makes it
easy to forget about it, and risk some change adding the inclusion
of a system header before including py-events.h, etc. But since
we don't have consensus, I'll leave it at that.
--
Pedro Alves