This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Multi-process + multi-arch: GDB


On 11/09/2012 06:24 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> +/* This is a convenience wrapper for 'current_inferior ()->gdbarch'.  */
> Pedro> +#define target_gdbarch get_target_gdbarch ()
> Pedro> +extern struct gdbarch *get_target_gdbarch (void);
> 
> I think object-like macros that expand to functions make the code harder
> to read.
> 
> I can write up a patch to fix this if you agree.

Please go ahead.  400 lines to touch, but you can easily sed/script it,
I guess.  I'd rather keep get_target_gdbarch() than do a full expansion to
"current_inferior ()->gdbarch", though.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]