This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA-v2] ARI fixes: Remove some sprintf calls



> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé?: jeudi 8 novembre 2012 22:35
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFA] ARI fixes: Remove some sprintf calls
> 
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
writes:
> 
> Pierre>   I do not commit this as obvious because,
> Pierre> I had to add some local variables to simplify
> Pierre> things for several cases.
> 
> Pierre>   Is this OK?
> 
> I like Andreas' suggestion.

  Me too, implemented below...

Thanks for the suggestion.
It's of course much better to have the size explicitly only at
one location, to avoid problems later.

 
> Also:
> 
> Pierre> +++ windows-nat.c	8 Nov 2012 15:03:15 -0000
> Pierre> @@ -613,6 +613,7 @@ struct safe_symbol_file_add_args
> Pierre>  struct lm_info
> Pierre>  {
> Pierre>    LPVOID load_addr;
> Pierre> +  unsigned long text_offset;
> Pierre>  };
> 
> Pierre>  static struct so_list solib_start, *solib_end;
> Pierre> @@ -778,6 +779,7 @@ windows_make_so (const char *name, LPVOI
> Pierre>      }
> Pierre>  #endif
> 
> Pierre> +
> Pierre>    return so;
> Pierre>  }
> 
> These hunks don't seem related to the patch.
  
  I am lucky not to have committed it as obvious...
Once again, I forgot that I had local, unsubmitted changes
lying around.

Hopefully fixes in this second version.

Is that one OK?

Pierre Muller


2012-11-11  Pierre Muller  <muller@sourceware.org>

        ARI fixes: Avoid sprintf function use rule.
        * charset.c (convert_between_encodings): Use xsnprintf.
        * cli-out.c (cli_field_int): Likewise.
        * cp-namespace.c (cp_lookup_nested_symbol): Likewise.
        * expprint.c (op_name_standard): Likewise.
        * frv-tdep.c (set_variant_num_gprs): Likewise.
        (set_variant_num_fprs): Likewise.
        * m68hc11-tdep.c (m68hc11_initialize_register_info): Likewise.
        * nto-tdep.c (nto_find_and_open_solib): Likewise.
        (nto_init_solib_absolute_prefix): Likewise.
        * source.c (init_source_path): Likewise.
        (print_source_lines_base): Likewise.
        * valprint.c (print_wchar): Likewise.
        * mi/mi-out.c (mi_field_int): Likewise.
        windows-nat.c (windows_pid_to_exec_file): Likewise.
        (windows_create_inferior): Likewise.
        (_initialize_check_for_gdb_ini): Likewise.

Attachment: sprintf-v1.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]