This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[obv] Use existed/supported commands in mi-cmd-param-changed.exp
- From: Yao Qi <yao at codesourcery dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Mon, 19 Nov 2012 23:04:22 +0800
- Subject: [obv] Use existed/supported commands in mi-cmd-param-changed.exp
Hi,
'maint set show-debug-regs' is an i386 specific command, so it doesn't
exist on other ports, such as arm. We'll see these errors in gdb.sum,
ERROR: Undefined command "maint set show-debug-regs on".
ERROR: Undefined command "maint set show-debug-regs off".
'set circular-trace-buffer' is not supported on ports other than x86
and x86_64.
This patch removes the test to remove the test to command
'maint set show-debug-regs', and replace 'set circular-trace-buffer'
with 'set remotecache' which exists on all ports.
I'll commit it in two days if no one has comments.
gdb/testsuite:
2012-11-19 Yao Qi <yao@codesourcery.com>
* gdb.mi/mi-cmd-param-changed.exp (test_command_param_changed):
Don't test 'maint set show-debug-regs'.
Use command 'set remotecache' instead of
'set circular-trace-buffer'.
---
gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp b/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp
index 8c2195c..7786f90 100644
--- a/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp
+++ b/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp
@@ -52,7 +52,7 @@ proc test_command_param_changed { } { with_test_prefix "cmd param" {
"\"set scheduler-locking stepr\" no event"
- foreach command { "circular-trace-buffer" "check type" } {
+ foreach command { "remotecache" "check type" } {
# The default value of each command option may be different, so we first
# set it to 'off', and this may or may not trigger MI notification.
@@ -81,12 +81,10 @@ proc test_command_param_changed { } { with_test_prefix "cmd param" {
}
# No notification is emitted for 'maint set' commands.
- foreach command { "profile" "show-debug-regs" } {
- foreach boolean_opt { "on" "off" } {
- mi_gdb_test "maint set ${command} ${boolean_opt}" \
- "\\&\"maint set ${command} ${boolean_opt}\\\\n\"\r\n\\^done" \
- "\"maint set ${command} ${boolean_opt}\""
- }
+ foreach boolean_opt { "on" "off" } {
+ mi_gdb_test "maint set profile ${boolean_opt}" \
+ "\\&\"maint set profile ${boolean_opt}\\\\n\"\r\n\\^done" \
+ "\"maint set profile ${boolean_opt}\""
}
# Full command parameters are included in the notification when a
--
1.7.7.6