This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Pass 'saved_singlestep_ptid' to deprecated_context_hook.
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 19 Nov 2012 15:28:36 +0000
- Subject: Re: [PATCH] Pass 'saved_singlestep_ptid' to deprecated_context_hook.
- References: <1353294224-3709-1-git-send-email-yao@codesourcery.com>
On 11/19/2012 03:03 AM, Yao Qi wrote:
> Hi,
> I read this part, and it looks incorrect to me. context_switch is called
> with parameter 'saved_singlestep_ptid' first and then,
> deprecated_context_hook should be called with 'saved_singlestep_ptid' as
> well.
Yeah.
>
> This part was last changed by this patch, and it looks an oversight that
> parameter for deprecated_context_hook is not updated to
> 'saved_singlestep_ptid'.
Indeed.
> Rebuilt GDB, but don't run regression test, because deprecated_context_hook
> is not installed in GDB.
Yeah. It's used by insight.
BTW, my WIP software single-step patches remove this whole
stepping_past_singlestep_breakpoint block/code.
> 2012-11-18 Yao Qi <yao@codesourcery.com>
>
> * infrun.c (handle_inferior_event): Pass 'saved_singlestep_ptid'
> to deprecated_context_hook.
OK. Thanks.
--
Pedro Alves